Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rust] improvements in agama logs store #1762

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[rust] improvements in agama logs store #1762

wants to merge 11 commits into from
+75 −21

Conversation

mchf
Copy link
Contributor

@mchf mchf commented Nov 14, 2024 •
edited
Loading

Problem

  • some information were missed in the result

Solution

  • added journal output for (new) agama-web-server
  • collected package versions (either .packages.root or "rpm -qa")
  • minor improvements - do not include empty files (when command produces no output) into the resulting archive; do not mask errors reported by the backend (either authentication required)
  • added service running busctl monitor on agama's bus in the background and collectin errors in dbus.log, the log file is then put into the resulting archive

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Nov 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12065382878

Details

  • 0 of 19 (0.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 71.329%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-cli/src/logs.rs 0 1 0.0%
rust/agama-lib/src/base_http_client.rs 0 6 0.0%
rust/agama-lib/src/logs.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/base_http_client.rs 1 53.85%
Totals Coverage Status
Change from base Build 11887235390: -0.02%
Covered Lines: 16922
Relevant Lines: 23724
💛 - Coveralls

@mchf mchf requested a review from imobachgs November 22, 2024 14:55
@mchf mchf marked this pull request as ready for review November 24, 2024 17:14
imobachgs
imobachgs reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looking much better now. Thanks!

service/share/agama-dbus-monitor.service Show resolved Hide resolved
rust/agama-lib/src/logs.rs Outdated Show resolved Hide resolved
@mchf mchf requested a review from imobachgs November 28, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs Awaiting requested review from imobachgs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchf @coveralls @imobachgs